Chromium Code Reviews| Index: build/config/compiler/BUILD.gn |
| diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn |
| index 8f5712039c167f581c359ebcc3ded33bf3fc076c..a43dc3bb685694ac2db120fbbd6c70276521977a 100644 |
| --- a/build/config/compiler/BUILD.gn |
| +++ b/build/config/compiler/BUILD.gn |
| @@ -1691,6 +1691,20 @@ config("no_symbols") { |
| } |
| } |
| +# On Linux and Android, the "grit" template wants to disable the warning about |
| +# unknown pragmas. However since gn does not deduplicate the flags from configs |
| +# but only the config themselves, if the template declare a "config" for that |
|
Benoit L
2017/02/23 14:59:22
nit: declares
sdefresne
2017/02/23 16:54:39
Done.
|
| +# purpose, the flag will end up being repeated for each dependent "grit" target. |
| +# Using a separate config solve this problem. |
|
Benoit L
2017/02/23 14:59:22
nit: solves
sdefresne
2017/02/23 16:54:39
Done.
|
| +config("disable_unknown_pragma") { |
| + if (is_clang) { |
| + cflags = [ |
| + "-Wunknown-pragmas", |
| + "-Wno-error=unknown-pragmas", |
| + ] |
| + } |
| +} |
| + |
| # Default symbols. |
| config("default_symbols") { |
| if (symbol_level == 0) { |