Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: tools/grit/grit_rule.gni

Issue 2717493002: Fix repeated "-Wunknown-pragmas -Wno-error=unknown-pragmas". (Closed)
Patch Set: Fix grammar errors. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Instantiate grit. This will produce a script target to run grit, and a 5 # Instantiate grit. This will produce a script target to run grit, and a
6 # static library that compiles the .cc files. 6 # static library that compiles the .cc files.
7 # 7 #
8 # Parameters 8 # Parameters
9 # 9 #
10 # source (required) 10 # source (required)
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 # change this to including absolute paths relative to the root gen directory 350 # change this to including absolute paths relative to the root gen directory
351 # (like "mycomponent/foo.h"). This config sets up the include path. 351 # (like "mycomponent/foo.h"). This config sets up the include path.
352 grit_config = target_name + "_grit_config" 352 grit_config = target_name + "_grit_config"
353 config(grit_config) { 353 config(grit_config) {
354 if (!defined(invoker.use_qualified_include) || 354 if (!defined(invoker.use_qualified_include) ||
355 !invoker.use_qualified_include) { 355 !invoker.use_qualified_include) {
356 include_dirs = [ output_dir ] 356 include_dirs = [ output_dir ]
357 } 357 }
358 358
359 if ((is_linux || is_android) && enable_resource_whitelist_generation) { 359 if ((is_linux || is_android) && enable_resource_whitelist_generation) {
360 cflags = [ 360 configs += [ "//build/config/compiler:disable_unknown_pragma" ]
361 "-Wunknown-pragmas",
362 "-Wno-error=unknown-pragmas",
363 ]
364 } 361 }
365 visibility = target_visibility 362 visibility = target_visibility
366 } 363 }
367 364
368 grit_custom_target = target_name + "_grit" 365 grit_custom_target = target_name + "_grit"
369 action(grit_custom_target) { 366 action(grit_custom_target) {
370 script = "//tools/grit/grit.py" 367 script = "//tools/grit/grit.py"
371 368
372 inputs = [ 369 inputs = [
373 invoker.source, 370 invoker.source,
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 if (defined(invoker.configs)) { 486 if (defined(invoker.configs)) {
490 configs += invoker.configs 487 configs += invoker.configs
491 } 488 }
492 489
493 if (defined(invoker.visibility)) { 490 if (defined(invoker.visibility)) {
494 visibility = invoker.visibility 491 visibility = invoker.visibility
495 } 492 }
496 output_name = grit_output_name 493 output_name = grit_output_name
497 } 494 }
498 } 495 }
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698