Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: content/browser/media/url_provision_fetcher.cc

Issue 2717483002: Network traffic annotation added to url_provision_fetcher. (Closed)
Patch Set: Annotation updated. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/url_provision_fetcher.cc
diff --git a/content/browser/media/url_provision_fetcher.cc b/content/browser/media/url_provision_fetcher.cc
index b3a241fa073e6eb8d211ad0dcc48204c97e0932b..59146379899270f324cd9fafe99a769a60678fc7 100644
--- a/content/browser/media/url_provision_fetcher.cc
+++ b/content/browser/media/url_provision_fetcher.cc
@@ -7,6 +7,7 @@
#include "base/memory/ptr_util.h"
#include "content/public/browser/provision_fetcher_factory.h"
#include "media/base/bind_to_current_loop.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
using net::URLFetcher;
@@ -32,7 +33,32 @@ void URLProvisionFetcher::Retrieve(
DVLOG(1) << __func__ << ": request:" << request_string;
DCHECK(!request_);
- request_ = URLFetcher::Create(GURL(request_string), URLFetcher::POST, this);
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("url_prevision_fetcher", R"(
+ semantics {
+ sender: "ProvisionFetcher for Android MediaDrm"
+ description:
+ "Android MediaDrm (a part of encrypted content playback) requires "
+ "provisioning of the device. This is a request to provisioning "
+ "server."
+ trigger: "NotProvisionedException from MediaDrm"
Ramin Halavati 2017/03/09 06:28:47 Please be a little more specific for a not-softwar
+ data: "Opaque request generated by Android framework"
Ramin Halavati 2017/03/09 06:28:47 Ditto.
+ destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER
Ramin Halavati 2017/03/09 06:28:47 Isn't it sent to a website that belongs to Google?
+ }
+ policy {
+ cookies_allowed: false/true
Ramin Halavati 2017/03/09 06:28:47 I don't see disabling cookies in the code. If you
+ cookies_store: "..."
+ setting: "..."
+ policy {
+ [POLICY_NAME] {
+ policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+ value: ...
+ }
+ }
+ policy_exception_justification: "..."
Ramin Halavati 2017/03/09 06:28:47 If there is no chrome policy implemented to preven
+ })");
+ request_ = URLFetcher::Create(GURL(request_string), URLFetcher::POST, this,
+ traffic_annotation);
// SetUploadData is mandatory even if we are not uploading anything.
request_->SetUploadData("", "");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698