third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js - Issue 2717393003: [DevTools] Turn starting tracing into promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2717393003: [DevTools] Turn starting tracing into promise. (Closed)

Patch Set: more work Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/tracing.html ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

index bf980891a8fb9d32d6c65f6c5da397b9787652ed..a86b299d3714e6f9ee75471f1aed30a2deeed75c 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

@@ -356,7 +356,7 @@ SDK.ResourceTreeModel = class extends SDK.SDKModel {

reloadPage(bypassCache, scriptToEvaluateOnLoad) {

// Only dispatch PageReloadRequested upon first reload request to simplify client logic.

if (!this._pendingReloadOptions)

- this.dispatchEventToListeners(SDK.ResourceTreeModel.Events.PageReloadRequested);

+ this.dispatchEventToListeners(SDK.ResourceTreeModel.Events.PageReloadRequested, this);

if (this._reloadSuspensionCount) {

this._pendingReloadOptions = [bypassCache, scriptToEvaluateOnLoad];

return;