Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

Issue 2717393003: [DevTools] Turn starting tracing into promise. (Closed)
Patch Set: more work Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
index 75c0022cf9ab6b239c88b62695ccc9dddbe4ca99..4013afd509c0d689a7f5ed563068a8d44e73168a 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
@@ -90,10 +90,11 @@ InspectorTest.invokeWithTracing = function(functionName, callback, additionalCat
var timelinePanel = UI.panels.timeline;
var timelineController = InspectorTest.timelineController();
timelinePanel._timelineController = timelineController;
- timelineController._startRecordingWithCategories(categories, enableJSSampling, tracingStarted);
+ timelineController._startRecordingWithCategories(categories, enableJSSampling).then(tracingStarted);
alph 2017/02/28 03:11:24 await
dgozman 2017/02/28 08:59:01 No, thanks :-)
function tracingStarted()
{
+ timelinePanel._recordingStarted();
InspectorTest.callFunctionInPageAsync(functionName).then(onPageActionsDone);
}
@@ -144,7 +145,7 @@ InspectorTest.runWhenTimelineIsReady = function(callback)
InspectorTest.startTimeline = function(callback)
{
var panel = UI.panels.timeline;
- InspectorTest.addSniffer(panel, "recordingStarted", callback);
+ InspectorTest.addSniffer(panel, "_recordingStarted", callback);
panel._toggleRecording();
};

Powered by Google App Engine
This is Rietveld 408576698