third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js - Issue 2717393003: [DevTools] Turn starting tracing into promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

Issue 2717393003: [DevTools] Turn starting tracing into promise. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

index 75c0022cf9ab6b239c88b62695ccc9dddbe4ca99..c38ecd05436c89a8c393692f7302a37d80b77e84 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

@@ -90,7 +90,7 @@ InspectorTest.invokeWithTracing = function(functionName, callback, additionalCat

var timelinePanel = UI.panels.timeline;

var timelineController = InspectorTest.timelineController();

timelinePanel._timelineController = timelineController;

- timelineController._startRecordingWithCategories(categories, enableJSSampling, tracingStarted);

+ timelineController._startRecordingWithCategories(categories, enableJSSampling).then(tracingStarted);

function tracingStarted()

{