Add Physical Web WebUI Default Url Icon

components/physical_web/webui/resources/physical_web.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Takes the |nearbyUrlsData| input argument which holds metadata for web pages
  * broadcast by nearby devices.
  * @param {Object} nearbyUrlsData Information about web pages broadcast by
  *      nearby devices
  */
 function renderTemplate(nearbyUrlsData) {
   // This is the javascript code that processes the template:
   jstProcess(new JsEvalContext(nearbyUrlsData), $('physicalWebTemplate'));
 }
 
 function requestNearbyURLs() {
   chrome.send('requestNearbyURLs');
 }
 
 function physicalWebItemClicked(index) {
   chrome.send('physicalWebItemClicked', [index]);
 }
 
 function returnNearbyURLs(nearbyUrlsData) {
   var bodyContainer = $('body-container');
   renderTemplate(nearbyUrlsData);
+  bodyContainer.style.visibility = 'visible';

[mmocny, 2017/03/02 17:13:35]

Nit: could you create a CSS class for hidden items, and then add/remove the
class instead of manually adjusting styles like this?

You can use Element.classList.add/remove to this:
https://developer.mozilla.org/en/docs/Web/API/Element/classList

[Ran, 2017/03/23 16:56:26]

Done.

+  addErrorHandler();
+}
 
-  bodyContainer.style.visibility = 'visible';
+function addErrorHandler() {

[mmocny, 2017/03/02 17:13:35]

Please rename: `assignImageLoadErrorHandlers`

[Ran, 2017/03/23 16:56:26]

Done.

+  var images = document.getElementsByTagName('img');

[Matt Reynolds, 2017/03/02 01:02:39]

Would getElementsByName work here to get only the favicons?

[mmocny, 2017/03/02 17:13:35]

Nit: chrome support `let` keyword now, which is more sane.

It doesn't matter much for `images` variable, but your use of `i` and `img`
later on are not scoped the way you expect.

[mmocny, 2017/03/02 17:13:35]

Personally I like using document.querySelector() (or document.querySelectorAll()
in this case) since it uses the same syntax as your CSS selectors.  Its
trivially less efficient (for this size UI).

https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelector
https://developer.mozilla.org/en-US/docs/Web/API/Document/querySelector

[Ran, 2017/03/23 16:56:26]

Done.

[Ran, 2017/03/23 16:56:26]

Done.

[Ran, 2017/03/23 16:56:26]

Done.

+  for (var i = 0; i < images.length; i++) {
+    var img = images[i];
+    img.addEventListener('error', function() {
+      this.src = "chrome://physical-web/link.png";

[Matt Reynolds, 2017/03/02 01:02:39]

Use a relative path here (relative to the webui URL chrome://physical-web/)

Also, shouldn't this be ic_link_grey600_36dp.png?

[Ran, 2017/03/23 16:56:25]

Done.

+    });
+  }
 }
 
 document.addEventListener('DOMContentLoaded', requestNearbyURLs);