Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 271733007: Make safely-roll-deps work with git commit hashes (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, eseidel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make safely-roll-deps work with git commit hashes BUG=skia:1945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269359

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/safely-roll-deps.py View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
borenet
Used to create (weird cross-SCM) CL: https://codereview.chromium.org/267283008
6 years, 7 months ago (2014-05-08 15:13:36 UTC) #1
M-A Ruel
lgtm with stricter regexp. https://codereview.chromium.org/271733007/diff/1/tools/safely-roll-deps.py File tools/safely-roll-deps.py (right): https://codereview.chromium.org/271733007/diff/1/tools/safely-roll-deps.py#newcode36 tools/safely-roll-deps.py:36: old_line = r'(\s+)"%s_revision": "(.+)",' % ...
6 years, 7 months ago (2014-05-08 16:44:34 UTC) #2
borenet
https://codereview.chromium.org/271733007/diff/1/tools/safely-roll-deps.py File tools/safely-roll-deps.py (right): https://codereview.chromium.org/271733007/diff/1/tools/safely-roll-deps.py#newcode36 tools/safely-roll-deps.py:36: old_line = r'(\s+)"%s_revision": "(.+)",' % project On 2014/05/08 16:44:34, ...
6 years, 7 months ago (2014-05-08 17:10:58 UTC) #3
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-08 17:11:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/271733007/20001
6 years, 7 months ago (2014-05-08 17:17:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 22:30:06 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 17:25:42 UTC) #7
Message was sent while issue was closed.
Change committed as 269359

Powered by Google App Engine
This is Rietveld 408576698