Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 271733005: Shorten autogenerated error message for functions only. (Closed)

Created:
6 years, 7 months ago by aandrey
Modified:
6 years, 7 months ago
Reviewers:
rossberg, Yang
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Shorten autogenerated error message for functions only. R=yangguo@chromium.org, Yang, rossberg@chromium.org BUG=v8:3019, chromium:331971 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=21224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M src/messages.js View 2 chunks +9 lines, -6 lines 0 comments Download
M test/mjsunit/error-tostring-omit.js View 1 chunk +5 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aandrey
6 years, 7 months ago (2014-05-08 14:16:16 UTC) #1
aandrey
ptal
6 years, 7 months ago (2014-05-08 14:17:00 UTC) #2
Yang
On 2014/05/08 14:17:00, aandrey wrote: > ptal LGTM. Though it's not clear why you are ...
6 years, 7 months ago (2014-05-08 14:32:30 UTC) #3
aandrey
On 2014/05/08 14:32:30, Yang wrote: > On 2014/05/08 14:17:00, aandrey wrote: > > ptal > ...
6 years, 7 months ago (2014-05-08 14:50:46 UTC) #4
Yang
On 2014/05/08 14:50:46, aandrey wrote: > On 2014/05/08 14:32:30, Yang wrote: > > On 2014/05/08 ...
6 years, 7 months ago (2014-05-08 14:52:40 UTC) #5
Yang
On 2014/05/08 14:52:40, Yang wrote: > On 2014/05/08 14:50:46, aandrey wrote: > > On 2014/05/08 ...
6 years, 7 months ago (2014-05-08 14:53:00 UTC) #6
Yang
6 years, 7 months ago (2014-05-09 13:14:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r21224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698