Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp

Issue 2717303002: Considering HTMLTokenizer state in HTMLSourceTracker (Closed)
Patch Set: Considering HTMLTokenizer state in HTMLSourceTracker Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp b/third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp
index aaec23e519e49a975365549964c783acefc9164b..e4e329fb837e227f1a88132dd33f1bb8023c5c6c 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp
@@ -37,10 +37,12 @@ void HTMLSourceTracker::start(SegmentedString& currentInput,
HTMLToken& token) {
if (token.type() == HTMLToken::Uninitialized && !m_isStarted) {
m_previousSource.clear();
- if (tokenizer->numberOfBufferedCharacters())
+ if (needToCheckTokenizerBuffer(tokenizer) &&
+ tokenizer->numberOfBufferedCharacters())
m_previousSource = tokenizer->bufferedCharacters();
- } else
+ } else {
m_previousSource.append(m_currentSource);
+ }
m_isStarted = true;
m_currentSource = currentInput;
@@ -56,8 +58,12 @@ void HTMLSourceTracker::end(SegmentedString& currentInput,
m_cachedSourceForToken = String();
// FIXME: This work should really be done by the HTMLTokenizer.
+ size_t numberOfBufferedCharacters = 0u;
+ if (needToCheckTokenizerBuffer(tokenizer)) {
+ numberOfBufferedCharacters = tokenizer->numberOfBufferedCharacters();
+ }
token.end(currentInput.numberOfCharactersConsumed() -
- tokenizer->numberOfBufferedCharacters());
+ numberOfBufferedCharacters);
}
String HTMLSourceTracker::sourceForToken(const HTMLToken& token) {
@@ -92,4 +98,13 @@ String HTMLSourceTracker::sourceForToken(const HTMLToken& token) {
return m_cachedSourceForToken;
}
+bool HTMLSourceTracker::needToCheckTokenizerBuffer(HTMLTokenizer* tokenizer) {
+ HTMLTokenizer::State state = tokenizer->getState();
+ // The temporary buffer must not be used unconditionally, because in some
+ // states (e.g. ScriptDataDoubleEscapedStartState), data is appended to
+ // both the temporary buffer and the token itself.
+ return state == HTMLTokenizer::DataState ||
+ HTMLTokenizer::isEndTagBufferingState(state);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698