Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2717233004: Extract ExpressionParserText from SimpleParserTest. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract ExpressionParserText from SimpleParserTest. So that we can run this portion of tests with Fasta. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6d231ad0efbc5f86566d04dafa0a1d4cfb2b468b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6404 lines, -6387 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 5 chunks +6396 lines, -6387 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 9 months ago (2017-02-27 20:30:15 UTC) #1
Paul Berry
lgtm assuming "Text" is changed to "Test". https://codereview.chromium.org/2717233004/diff/1/pkg/analyzer/test/generated/parser_test.dart File pkg/analyzer/test/generated/parser_test.dart (right): https://codereview.chromium.org/2717233004/diff/1/pkg/analyzer/test/generated/parser_test.dart#newcode3954 pkg/analyzer/test/generated/parser_test.dart:3954: class ExpressionParserText ...
3 years, 9 months ago (2017-02-27 20:39:39 UTC) #2
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-02-27 20:47:05 UTC) #3
scheglov
3 years, 9 months ago (2017-02-27 20:48:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6d231ad0efbc5f86566d04dafa0a1d4cfb2b468b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698