Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5790)

Unified Diff: chrome/browser/resources/chromeos/braille_ime/check_braille_ime.py

Issue 271723002: Make Braille IME send space bar as an empty cell instead of letting propagate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ime
Patch Set: Simplify a check. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/braille_ime/check_braille_ime.py
diff --git a/chrome/browser/resources/chromeos/braille_ime/check_braille_ime.py b/chrome/browser/resources/chromeos/braille_ime/check_braille_ime.py
index 9e72cb9bd3331b1bd2bca5b5693b159aa6499607..c943ff9b4f638ee654103bd7bc6738c482e94a0f 100755
--- a/chrome/browser/resources/chromeos/braille_ime/check_braille_ime.py
+++ b/chrome/browser/resources/chromeos/braille_ime/check_braille_ime.py
@@ -60,9 +60,9 @@ def _run_closure_compiler():
args = [_java_executable, '-jar', _CLOSURE_COMPILER_JAR]
args.extend(['--compilation_level', 'SIMPLE_OPTIMIZATIONS'])
args.extend(['--jscomp_error=%s' % error for error in _JSCOMP_ERRORS])
- args.extend(['--externs', 'externs.js'])
- args.extend(['--js', 'braille_ime.js'])
- args.extend(['--js', 'main.js'])
+ args.extend(['--externs', os.path.join(_SCRIPT_DIR, 'externs.js')])
+ args.extend(['--js', os.path.join(_SCRIPT_DIR, 'braille_ime.js')])
+ args.extend(['--js', os.path.join(_SCRIPT_DIR, 'main.js')])
args.extend(['--js_output_file', '/dev/null'])
output = _execute_command(args, ignore_exit_status=True)
success = len(output) == 0

Powered by Google App Engine
This is Rietveld 408576698