Make Braille IME send space bar as an empty cell instead of letting propagate.

chrome/browser/resources/chromeos/braille_ime/braille_ime.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview Braille hardware keyboard input method.
  *
  * This method is automatically enabled when a braille display is connected
@@ skipping 75 matching lines @@
    * @private {number}
    */
   accumulated_: 0,
 
   /**
    * Maps key codes on a standard keyboard to the correspodning dots.
    * Keys on the 'home row' correspond to the keys on a Perkins-style keyboard.
    * Note that the mapping below is arranged like the dots in a braille cell.
    * Only 6 dot input is supported.
    * @private
-   * @const {Object.<string, string>}
+   * @const {Object.<string, number>}
    */
   CODE_TO_DOT_: {'KeyF': 0x01, 'KeyJ': 0x08,
                  'KeyD': 0x02, 'KeyK': 0x10,
-                 'KeyS': 0x04, 'KeyL': 0x20 },
+                 'KeyS': 0x04, 'KeyL': 0x20 ,

[David Tseng, 2014/05/07 18:05:54]

nit: extra space before comma

+                 'Space': 0},

[David Tseng, 2014/05/07 18:05:54]

nit: space before }

 
   /**
    * The current engine ID as set by {@code onActivate}, or the empty string if
    * the IME is not active.
    * @type {string}
    * @private
    */
   engineID_: '',
 
   /**
@@ skipping 83 matching lines @@
   /**
    * Called by the system when this IME is active and a key event is generated.
    * @param {string} engineID Engine ID, should be 'braille'.
    * @param {!ChromeKeyboardEvent} event The keyboard event.
    * @return {boolean} Whether the event was handled by this IME (true) or
    *     should be allowed to propagate.
    * @private
    */
   onKeyEvent_: function(engineID, event) {
     this.log_('onKeyEvent', engineID + ', ' + JSON.stringify(event));
-    return this.processKey_(event.code, event.type);
+    return this.processKey_(event);
   },
 
   /**
    * Called when chrome ends the current text input session.
    * @param {string} engineID Engine ID, should be 'braille'.
    * @private
    */
   onReset_: function(engineID) {
     this.log_('onReset', engineID);
     this.engineID_ = engineID;
@@ skipping 30 matching lines @@
   log_: function(func, message) {
     if (func === 'onKeyEvent') {
       return;
     }
     if (this.DEBUG) {
       console.log('BrailleIme.' + func + ': ' + message);
     }
   },
 
   /**
    * Handles a querty key on the home row as a braille key.

[David Tseng, 2014/05/07 18:05:54]

nit: I think it's "qwerty"

-   * @param {string} code Key code.
-   * @param {string} type Type of key event.
+   * @param {!ChromeKeyboardEvent} event Keyboard event.
    * @return {boolean} Whether the key event was handled or not.
    * @private
    */
-  processKey_: function(code, type) {
+  processKey_: function(event) {
     if (!this.useStandardKeyboard_) {
       return false;
     }
-    var dot = this.CODE_TO_DOT_[code];
-    if (!dot) {
+    var dot = this.CODE_TO_DOT_[event.code];
+    if (dot === undefined || event.altKey || event.ctrlKey || event.shiftKey ||
+        event.capsLock) {
       this.pressed_ = 0;
       this.accumulated_ = 0;
       return false;
     }
-    if (type === 'keydown') {
-      this.pressed_ |= dot;
-      this.accumulated_ |= this.pressed_;
+    if (event.type === 'keydown') {
+      if (dot !== 0) {
+        this.pressed_ |= dot;
+        this.accumulated_ |= this.pressed_;
+      } else {
+        // Space cancels other dots.

[David Tseng, 2014/05/07 18:05:54]

Just wondering about the behavior here. If I hold down, say dots 1 and 2, and
tap the space key by mistake (with dots 1 and 2 still held down), this would
cancel dots 1 and 2? Is that something we want?

+        this.pressed_ = this.accumulated_ = 0;
+      }
       return true;
-    } else if (type == 'keyup') {
+    } else if (event.type === 'keyup') {
       this.pressed_ &= ~dot;
-      if (this.pressed_ == 0 && this.accumulated_ != 0) {
+      if (this.pressed_ === 0 && (this.accumulated_ !== 0 || dot === 0)) {
         this.sendToChromeVox_({type: 'brailleDots', dots: this.accumulated_});
         this.accumulated_ = 0;
       }
       return true;
     }
     return false;
   },
 
   /**
    * Connects to the ChromeVox extension for message passing.
@@ skipping 116 matching lines @@
              label: 'Use standard keyboard for braille',
              style: 'check',
              visible: true,
              checked: this.useStandardKeyboard_,
              enabled: true
              }
          ]
         });
   }
 };