Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: components/crash/content/app/crash_reporter_client.h

Issue 2717223003: Add WebView-specific whitelist for crash keys. (Closed)
Patch Set: Init whitelist vars in breakpad_linux + move crash-calls from aw_debug to aw/crash_keys (to avoid a… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crash_reporter_client.h
diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h
index 513727c08f3f434365e4df6d12ec8bf482104b95..f0a55e8a397a7048f3efe9ff49bc6361a9b65952 100644
--- a/components/crash/content/app/crash_reporter_client.h
+++ b/components/crash/content/app/crash_reporter_client.h
@@ -144,6 +144,11 @@ class CrashReporterClient {
// reporting server. Returns the size of the union of all keys.
virtual size_t RegisterCrashKeys();
+ virtual bool UseCrashKeysWhiteList();
Robert Sesek 2017/03/02 22:29:40 How about ShouldWhiteListCrashKeys() ?
Robert Sesek 2017/03/02 23:10:49 On second thought, your name is better. Ignore.
+
+ // Returns a NULL-terminated array of crash keys to whitelist.
+ virtual const char** GetWhiteListedCrashKeys();
Robert Sesek 2017/03/02 22:29:40 And GetCrashKeyWhiteList().
gsennton 2017/03/03 00:09:32 Done.
+
// Returns true if running in unattended mode (for automated testing).
virtual bool IsRunningUnattended();

Powered by Google App Engine
This is Rietveld 408576698