Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: components/crash/content/app/crash_reporter_client.h

Issue 2717223003: Add WebView-specific whitelist for crash keys. (Closed)
Patch Set: Use non-allocating whitelist implementation. Add instrumentation tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crash_reporter_client.h
diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h
index 513727c08f3f434365e4df6d12ec8bf482104b95..7f6f878af56cc7fcf4281a4812e10b315806541a 100644
--- a/components/crash/content/app/crash_reporter_client.h
+++ b/components/crash/content/app/crash_reporter_client.h
@@ -8,6 +8,7 @@
#include <stddef.h>
#include <string>
+#include <vector>
#include "base/strings/string16.h"
#include "build/build_config.h"
@@ -144,6 +145,10 @@ class CrashReporterClient {
// reporting server. Returns the size of the union of all keys.
virtual size_t RegisterCrashKeys();
+ virtual bool UseCrashKeysWhiteList();
+
+ virtual std::vector<const char*> GetWhiteListedCrashKeys();
Tobias Sargeant 2017/02/28 22:18:55 Because the whitelist is not accessed in a comprom
gsennton 2017/03/01 15:53:02 If there aren't any whitelisted keys, shouldn't th
+
// Returns true if running in unattended mode (for automated testing).
virtual bool IsRunningUnattended();

Powered by Google App Engine
This is Rietveld 408576698