Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1918)

Unified Diff: android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

Issue 2717223003: Add WebView-specific whitelist for crash keys. (Closed)
Patch Set: Use non-allocating whitelist implementation. Add instrumentation tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
diff --git a/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc b/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
index 44c3b7cc8712b30377f5f9987edb08ba33059bbc..f7b3b0b23b98d3c38b2c02ab5d159a1a2597b817 100644
--- a/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
+++ b/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc
@@ -10,6 +10,7 @@
#include "android_webview/common/crash_reporter/crash_keys.h"
#include "base/android/build_info.h"
#include "base/base_paths_android.h"
+#include "base/debug/crash_logging.h"
#include "base/debug/dump_without_crashing.h"
#include "base/files/file_path.h"
#include "base/lazy_instance.h"
@@ -36,6 +37,8 @@ class AwCrashReporterClient : public ::crash_reporter::CrashReporterClient {
// crash_reporter::CrashReporterClient implementation.
size_t RegisterCrashKeys() override;
+ bool UseCrashKeysWhiteList() override { return true; }
+ std::vector<const char*> GetWhiteListedCrashKeys() override;
bool IsRunningUnattended() override { return false; }
bool GetCollectStatsConsent() override {
@@ -86,6 +89,10 @@ size_t AwCrashReporterClient::RegisterCrashKeys() {
return crash_keys::RegisterWebViewCrashKeys();
}
+std::vector<const char*> AwCrashReporterClient::GetWhiteListedCrashKeys() {
+ return crash_keys::GetWhiteListedWebViewCrashKeys();
+}
+
base::LazyInstance<AwCrashReporterClient>::Leaky g_crash_reporter_client =
LAZY_INSTANCE_INITIALIZER;

Powered by Google App Engine
This is Rietveld 408576698