Add WebView-specific whitelist for crash keys.

components/crash/content/app/breakpad_linux.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // For linux_syscall_support.h. This makes it safe to call embedded system
 // calls when in seccomp mode.
 
 #include "components/crash/content/app/breakpad_linux.h"
 
 #include <fcntl.h>
@@ skipping 1080 matching lines @@
       MinidumpDescriptor("/tmp"),  // Unused but needed or Breakpad will assert.
       nullptr,
       nullptr,
       nullptr,
       true,
       -1);
   g_breakpad->set_crash_generation_client(new NonBrowserCrashHandler());
 }
 #endif  // defined(OS_ANDROID)
 
+bool g_use_crash_keys_whitelist;

[Tobias Sargeant, 2017/03/02 16:36:48]

initialize these, and move them to the top of the file.

[gsennton, 2017/03/02 17:35:37]

Done.

+const char** g_crash_keys_whitelist;
+
+bool IsInWhiteList(const base::StringPiece& key) {
+  DCHECK(g_crash_keys_whitelist);
+  for (size_t i = 0; g_crash_keys_whitelist[i] != NULL; ++i) {
+    if (0 == my_strcmp(g_crash_keys_whitelist[i], key.data())) {
+      return true;
+    }
+  }
+  return false;
+}
+
 void SetCrashKeyValue(const base::StringPiece& key,
                       const base::StringPiece& value) {
-  g_crash_keys->SetKeyValue(key.data(), value.data());
+  if (!g_use_crash_keys_whitelist || IsInWhiteList(key)) {
+    g_crash_keys->SetKeyValue(key.data(), value.data());
+  }
 }
 
 void ClearCrashKey(const base::StringPiece& key) {
   g_crash_keys->RemoveKey(key.data());
 }
 
 // GetCrashReporterClient() cannot call any Set methods until after
 // InitCrashKeys().
 void InitCrashKeys() {
   g_crash_keys = new CrashKeyStorage;
   GetCrashReporterClient()->RegisterCrashKeys();
+  g_use_crash_keys_whitelist =
+      GetCrashReporterClient()->UseCrashKeysWhiteList();
+  g_crash_keys_whitelist = GetCrashReporterClient()->GetWhiteListedCrashKeys();
   base::debug::SetCrashKeyReportingFunctions(&SetCrashKeyValue, &ClearCrashKey);
 }
 
 // Miscellaneous initialization functions to call after Breakpad has been
 // enabled.
 void PostEnableBreakpadInitialization() {
   SetProcessStartTime();
   g_pid = getpid();
 
   base::debug::SetDumpWithoutCrashingFunction(&DumpProcess);
@@ skipping 773 matching lines @@
 
 #if defined(OS_ANDROID)
 // In Android WebView, microdumps are generated conditionally (depending on the
 // cause of the crash) and can be sanitized to prevent exposing unnecessary data
 // from the embedding application.
 void InitCrashReporter(const std::string& process_type) {
   SanitizationInfo sanitization_info;
   InitCrashReporter(process_type, sanitization_info);
 }
 
+void InitCrashKeysForTesting() {
+  InitCrashKeys();
+}
+
 void InitCrashReporter(const std::string& process_type,
                        const SanitizationInfo& sanitization_info) {
 #else
 void InitCrashReporter(const std::string& process_type) {
 #endif  // defined(OS_ANDROID)
   // The maximum lengths specified by breakpad include the trailing NULL, so the
   // actual length of the chunk is one less.
   static_assert(crash_keys::kChunkMaxLength == 63, "kChunkMaxLength mismatch");
   static_assert(crash_keys::kSmallSize <= crash_keys::kChunkMaxLength,
                 "crash key chunk size too small");
@@ skipping 141 matching lines @@
 void SuppressDumpGeneration() {
   g_dumps_suppressed = G_DUMPS_SUPPRESSED_MAGIC;
 }
 #endif  // OS_ANDROID
 
 bool IsCrashReporterEnabled() {
   return g_is_crash_reporter_enabled;
 }
 
 }  // namespace breakpad