Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: android_webview/common/crash_reporter/aw_microdump_unittest.cc

Issue 2717223003: Add WebView-specific whitelist for crash keys. (Closed)
Patch Set: Use non-allocating whitelist implementation. Add instrumentation tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "android_webview/common/crash_reporter/crash_keys.h"
6 #include "testing/gtest/include/gtest/gtest.h"
7
8 class AwMicroDumpTest : public Test {
9 public:
10 AwMicroDumpUnittest() {}
11
12 protected:
13 };
14
15 TEST_F(AwMicroDumpTest, WhitelistedKeysAreRegistered) {
16 std::vector<const char*> whitelisted_keys =
17 crash_keys::GetWhiteListedWebViewCrashKeys();
18 std::vector<const char*> registered_keys =
19 crash_keys::GetWebViewCrashKeysToRegister();
20 // TODO ensure whitelisted_keys is a sub-set of registered keys (with
21 // special-cases for kMediumSize keys).
22 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698