Chromium Code Reviews| Index: cc/ipc/shared_bitmap_manager.mojom |
| diff --git a/cc/ipc/shared_bitmap_manager.mojom b/cc/ipc/shared_bitmap_manager.mojom |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..784caa25f7db2aec5b6eda371b6a957918a2bda4 |
| --- /dev/null |
| +++ b/cc/ipc/shared_bitmap_manager.mojom |
| @@ -0,0 +1,22 @@ |
| +// Copyright 2017 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
| +module cc.mojom; |
| + |
| +import "gpu/ipc/common/mailbox.mojom"; |
| + |
| +// This interface is used for allocating shared bitmap memory from display |
|
danakj
2017/04/06 15:00:51
I think this can be reworded a bit. The API doesn'
xlai (Olivia)
2017/04/06 20:42:26
Done here and elsewhere.
|
| +// compositor. For mus+ash, this service will live in where the display |
|
danakj
2017/04/06 15:00:51
And then I would drop the "For mus+ash..." sentenc
|
| +// compositor lives. |
| +// This interface needs to be associated with the RenderMessageFilter interface |
| +// to prevent running into message ordering issues (CC trying to access a |
| +// shared bitmap before the registration message below made it to the display |
| +// compositor). |
| +interface SharedBitmapManager { |
| + // Informs the display compositor that the child allocated a shared bitmap. |
| + AllocatedSharedBitmap(handle<shared_buffer> buffer, gpu.mojom.Mailbox id); |
|
Tom Sepez
2017/04/06 16:44:04
nit: maybe call this DidAllocateSharedBitmap(). O
|
| + |
| + // Informs the display compositor that the child deleted a shared bitmap. |
| + DeletedSharedBitmap(gpu.mojom.Mailbox id); |
|
Tom Sepez
2017/04/06 16:44:04
nit: maybe call this WillDeleteSharedBitmap(). Th
xlai (Olivia)
2017/04/06 20:42:26
Done here and elsewhere. I think this should be Di
|
| +}; |