components/display_compositor/child/BUILD.gn - Issue 2717213004: Move SharedBitmapManager implementation out of content/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/display_compositor/child/BUILD.gn

Issue 2717213004: Move SharedBitmapManager implementation out of content/ (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/display_compositor/DEPS ('k') | components/display_compositor/child/child_shared_bitmap_manager.h » ('j') | components/display_compositor/child/child_shared_bitmap_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//testing/test.gni")

	6

	7 component("child") {

	8 output_name = "display_compositor_child"

	9

	10 defines = [ "DISPLAY_COMPOSITOR_IMPLEMENTATION" ]
	danakj 2017/02/28 20:34:56 separate components should have separate IMPLEMENT separate components should have separate IMPLEMENTATION and export macros xlai (Olivia) 2017/03/01 20:02:45 This is not a separate implementation. It still be Show quoted text On 2017/02/28 20:34:56, danakj wrote: > separate components should have separate IMPLEMENTATION and export macros This is not a separate implementation. It still belongs to display_compositor, just like //components/discardable_memory/ having separate folders for renderer and browser respectively. danakj 2017/03/03 19:21:55 That makes me question this a bit more then. //com Show quoted text On 2017/03/01 20:02:45, xlai (Olivia) wrote: > On 2017/02/28 20:34:56, danakj wrote: > > separate components should have separate IMPLEMENTATION and export macros > > This is not a separate implementation. It still belongs to display_compositor, > just like //components/discardable_memory/ having separate folders for renderer > and browser respectively. That makes me question this a bit more then. //components/display_compositor is the cc embedder for the display compositor. But the child is not part of the display compositor so it should not be in that component.
	11

	12 sources = [

	13 "child_shared_bitmap_manager.cc",

	14 "child_shared_bitmap_manager.h",

	15 ]

	16

	17 deps = [

	18 "//base",

	19 "//cc",

	20 "//components/display_compositor",

	21 "//components/display_compositor/interfaces",

	22 "//mojo/public/cpp/bindings",

	23 "//ui/gfx",

	24 ]

	25 }

OLD	NEW