Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2717183002: Slim V8DOMConfiguration::MethodConfiguration by refactoring per-world bindings. (Closed)
Patch Set: haraken Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
index 899918e22b5ff64391577a89ccc246ce1b4d7c64..db7d317064bcfc1a874ee3e3ed3d7b9928ff6448 100644
--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
@@ -389,7 +389,7 @@ const V8DOMConfiguration::AccessorConfiguration {{v8_class}}Accessors[] = {
{% if methods | has_method_configuration(is_partial) %}
const V8DOMConfiguration::MethodConfiguration {{v8_class}}Methods[] = {
{% for method in methods | has_method_configuration(is_partial) %}
- {{method_configuration(method)}},
+ {{method_configuration(method) | indent(4)}},
{% endfor %}
};
@@ -671,8 +671,11 @@ void {{v8_class_or_partial}}::install{{feature.name}}(v8::Isolate* isolate, cons
{# Origin-Trial-enabled methods (no overloads) #}
{% for method in feature.methods %}
{% set method_name = method.name.title().replace('_', '') %}
- const V8DOMConfiguration::MethodConfiguration method{{method_name}}Configuration = {{method_configuration(method)}};
- V8DOMConfiguration::installMethod(isolate, world, instance, prototype, interface, signature, method{{method_name}}Configuration);
+ const V8DOMConfiguration::MethodConfiguration method{{method_name}}Configuration[] = {
+ {{method_configuration(method) | indent(2)}}
+ };
+ for (const auto& methodConfig : method{{method_name}}Configuration)
+ V8DOMConfiguration::installMethod(isolate, world, instance, prototype, interface, signature, methodConfig);
{% endfor %}
}

Powered by Google App Engine
This is Rietveld 408576698