NQE: Plumb RTT and throughput estimates to the UI thread

net/nqe/network_quality_estimator.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_
 #define NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 142 matching lines @@
    private:
     DISALLOW_COPY_AND_ASSIGN(ThroughputObserver);
   };
 
   // Provides simple interface to obtain the effective connection type.
   class NET_EXPORT NetworkQualityProvider {
    public:
     // Returns the current effective connection type.
     virtual EffectiveConnectionType GetEffectiveConnectionType() const = 0;
 
+    virtual ~NetworkQualityProvider() {}
+
     // Adds |observer| to a list of effective connection type observers.
     virtual void AddEffectiveConnectionTypeObserver(
         EffectiveConnectionTypeObserver* observer) = 0;
 
     // Removes |observer| from a list of effective connection type observers.
     virtual void RemoveEffectiveConnectionTypeObserver(
         EffectiveConnectionTypeObserver* observer) = 0;
 
-    virtual ~NetworkQualityProvider() {}
+    // Adds |observer| to the list of RTT and throughput estimate observers.
+    // |observer| would be notified of the current RTT and throughput estimates
+    // in the next message pump.
+    void AddRTTAndThroughputEstimatesObserver(

[RyanSturm, 2017/03/10 22:10:47]

virtual

+        RTTAndThroughputEstimatesObserver* observer) override;
+
+    // Removes |observer| from the list of RTT and throughput estimate
+    // observers.
+    void RemoveRTTAndThroughputEstimatesObserver(

[RyanSturm, 2017/03/10 22:10:47]

virtual

+        RTTAndThroughputEstimatesObserver* observer) override;
 
    protected:
     NetworkQualityProvider() {}
 
    private:
     DISALLOW_COPY_AND_ASSIGN(NetworkQualityProvider);
   };
 
   // Creates a new NetworkQualityEstimator.
   // |variation_params| is the map containing all field trial parameters
@@ skipping 46 matching lines @@
       EffectiveConnectionTypeObserver* observer);
 
   // Removes |observer| from the list of effective connection type observers.
   // Must be called on the IO thread.
   void RemoveEffectiveConnectionTypeObserver(
       EffectiveConnectionTypeObserver* observer);
 
   // Adds |observer| to the list of RTT and throughput estimate observers. Must
   // be called on the IO thread. |observer| would be notified of the current RTT
   // and throughput estimates in the next message pump.
   void AddRTTAndThroughputEstimatesObserver(

[RyanSturm, 2017/03/10 22:10:47]

Override

[tbansal1, 2017/03/10 23:22:10]

This is not going to work now since NQE does not implement
NetworkQualityProvider. If it is necessary, I can do it in future. It will also
require moving NetworkQualityProvider to a different file.

[tbansal1, 2017/03/10 23:22:11]

Done.

[RyanSturm, 2017/03/11 01:36:13]

Yup. No problem. I think eventually we might want to move it over, but since
they are both net layer interfaces I have no problem.

       RTTAndThroughputEstimatesObserver* observer);
 
   // Removes |observer| from the list of RTT and throughput estimate observers.
   // Must be called on the IO thread.
   void RemoveRTTAndThroughputEstimatesObserver(

[RyanSturm, 2017/03/10 22:10:47]

override

[tbansal1, 2017/03/10 23:22:10]

Done.

[tbansal1, 2017/03/10 23:22:11]

same as above.

       RTTAndThroughputEstimatesObserver* observer);
 
   // Notifies NetworkQualityEstimator that the response header of |request| has
   // been received.
   void NotifyHeadersReceived(const URLRequest& request);
 
   // Notifies NetworkQualityEstimator that the headers of |request| are about to
   // be sent.
   void NotifyStartTransaction(const URLRequest& request);
 
@@ skipping 35 matching lines @@
   // If |disable_offline_check| is set to true, then the device offline check is
   // disabled when computing the effective connection type or when writing the
   // prefs.
   void DisableOfflineCheckForTesting(bool disable_offline_check);
 
   // Reports |effective_connection_type| to all
   // EffectiveConnectionTypeObservers.
   void ReportEffectiveConnectionTypeForTesting(
       EffectiveConnectionType effective_connection_type);
 
+  // Reports the RTTs and throughput to all RTTAndThroughputEstimatesObservers.
+  void ReportRTTsAndThroughputForTesting(base::TimeDelta http_rtt,
+                                         base::TimeDelta transport_rtt,
+                                         int32_t downstream_throughput_kbps);
+
   // Adds and removes |observer| from the list of cache observers.
   void AddNetworkQualitiesCacheObserver(
       nqe::internal::NetworkQualityStore::NetworkQualitiesCacheObserver*
           observer);
   void RemoveNetworkQualitiesCacheObserver(
       nqe::internal::NetworkQualityStore::NetworkQualitiesCacheObserver*
           observer);
 
   // Called when the persistent prefs have been read. |read_prefs| contains the
   // parsed prefs as a map between NetworkIDs and CachedNetworkQualities.
@@ skipping 493 matching lines @@
       disallowed_observation_sources_for_transport_;
 
   base::WeakPtrFactory<NetworkQualityEstimator> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkQualityEstimator);
 };
 
 }  // namespace net
 
 #endif  // NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_