use canonical base URL for projects

use canonical base URL for projects

BUG=372645
R=iannucci@chromium.org, sergeyberezin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270460

[Sergey Berezin, 2014-05-13 18:55:22]

https://codereview.chromium.org/271703010/diff/1/git_cl.py
File git_cl.py (left):

https://codereview.chromium.org/271703010/diff/1/git_cl.py#oldcode1169
git_cl.py:1169: error_ok=False).strip()
Since you are modifying only chromium at the moment, I'd keep this command
intact. It allows developers to set custom base URL in case they need to fix it
in their checkout.

In fact, for the transition, I'd keep both .base-url and .canonical-url, with
the latter overriding the former.

https://codereview.chromium.org/271703010/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/271703010/diff/1/git_cl.py#newcode643
git_cl.py:643: error_ok=True).strip()
Let's continue checking .base-url if .canonical-url is not present. This allows
us to be backwards compatible with existing repo checkouts, and with repos that
have not transitioned yet to the canonical base URL.

We should phase .base-url config slowly over time once all the projects are
transitioned to the new scheme and have been using it for a while.

[sheyang, 2014-05-13 22:01:35]

https://codereview.chromium.org/271703010/diff/1/git_cl.py
File git_cl.py (left):

https://codereview.chromium.org/271703010/diff/1/git_cl.py#oldcode1169
git_cl.py:1169: error_ok=False).strip()
On 2014/05/13 18:55:22, Sergey Berezin wrote:
> Since you are modifying only chromium at the moment, I'd keep this command
> intact. It allows developers to set custom base URL in case they need to fix
it
> in their checkout.
> 
> In fact, for the transition, I'd keep both .base-url and .canonical-url, with
> the latter overriding the former.

Done.

https://codereview.chromium.org/271703010/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/271703010/diff/1/git_cl.py#newcode643
git_cl.py:643: error_ok=True).strip()
On 2014/05/13 18:55:22, Sergey Berezin wrote:
> Let's continue checking .base-url if .canonical-url is not present. This
allows
> us to be backwards compatible with existing repo checkouts, and with repos
that
> have not transitioned yet to the canonical base URL.
> 
> We should phase .base-url config slowly over time once all the projects are
> transitioned to the new scheme and have been using it for a while.

Done.

[Sergey Berezin, 2014-05-13 22:51:02]

LGTM + nits.

https://codereview.chromium.org/271703010/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/271703010/diff/20001/git_cl.py#newcode644
git_cl.py:644: error_ok=True).strip()
nit: It looks like the 'error_ok' argument is not indented as the previous
argument. Can you double-check the indentation?

I might have been like that originally, but let's fix it now.

https://codereview.chromium.org/271703010/diff/20001/git_cl.py#newcode647
git_cl.py:647: error_ok=True).strip()
Same as above.

https://codereview.chromium.org/271703010/diff/20001/git_cl.py#newcode647
git_cl.py:647: error_ok=True).strip()
Same as above.

[sheyang, 2014-05-13 23:38:54]

https://codereview.chromium.org/271703010/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/271703010/diff/20001/git_cl.py#newcode644
git_cl.py:644: error_ok=True).strip()
On 2014/05/13 22:51:07, Sergey Berezin wrote:
> nit: It looks like the 'error_ok' argument is not indented as the previous
> argument. Can you double-check the indentation?
> 
> I might have been like that originally, but let's fix it now.

Done.

https://codereview.chromium.org/271703010/diff/20001/git_cl.py#newcode647
git_cl.py:647: error_ok=True).strip()
On 2014/05/13 22:51:07, Sergey Berezin wrote:
> Same as above.

Done.

[iannucci, 2014-05-14 19:20:59]

lgtm

[sheyang, 2014-05-14 20:03:58]

Committed patchset #3 manually as r270460 (presubmit successful).

[sheyang, 2014-05-15 20:39:25]

A revert of this CL has been created in
https://codereview.chromium.org/287063002/ by sheyang@chromium.org.

The reason for reverting is: CQ rejects all chromium projects because of this
change..