Source/platform/heap/ThreadState.h - Issue 271703002: Simplify and speed up address-to-page cache for conservative stack scanning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.h

Issue 271703002: Simplify and speed up address-to-page cache for conservative stack scanning. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: There were some missing cache flushes. Strengthened asserts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/ThreadState.h

diff --git a/Source/platform/heap/ThreadState.h b/Source/platform/heap/ThreadState.h

index 555b5bd37e486ea54c4a35002626b42c8c52199c..79352b349bfd86465d06eacc2f018ab39135f4d7 100644

--- a/Source/platform/heap/ThreadState.h

+++ b/Source/platform/heap/ThreadState.h

@@ -467,7 +467,7 @@ public:

// address ranges for the Blink heap. If the address is in the Blink

// heap the containing heap page is returned.

HeapContainsCache* heapContainsCache() { return m_heapContainsCache.get(); }

- BaseHeapPage* contains(Address);

+ BaseHeapPage* contains(Address address) { return heapPageFromAddress(address); }

BaseHeapPage* contains(void* pointer) { return contains(reinterpret_cast<Address>(pointer)); }

BaseHeapPage* contains(const void* pointer) { return contains(const_cast<void*>(pointer)); }

« Source/platform/heap/Heap.cpp ('K') | « Source/platform/heap/HeapTest.cpp ('k') | Source/platform/heap/ThreadState.cpp » ('j') | Source/platform/heap/ThreadState.cpp » ('J')