MD Settings: Stop using prefs to populate import data dialog.

chrome/browser/resources/settings/people_page/import_data_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-import-data-dialog' is a component for importing
  * bookmarks and other data from other sources.
  */
 Polymer({
   is: 'settings-import-data-dialog',
 
-  behaviors: [I18nBehavior, WebUIListenerBehavior, PrefsBehavior],
+  behaviors: [I18nBehavior, WebUIListenerBehavior],
 
   properties: {
     /** @private {!Array<!settings.BrowserProfile>} */
     browserProfiles_: Array,
 
     /** @private {!settings.BrowserProfile} */
     selected_: Object,
 
     /**
      * Whether none of the import data categories is selected.
@@ skipping 11 matching lines @@
     },
 
     /**
      * Mirroring the enum so that it can be used from HTML bindings.
      * @private
      */
     importStatusEnum_: {
       type: Object,
       value: settings.ImportDataStatus,
     },
+
+    /** @private */
+    showBookmarkSuccess_: Boolean,
   },
 
-  observers: [
-    'prefsChanged_(selected_, prefs.*)',
-  ],
-
   /** @private {?settings.ImportDataBrowserProxy} */
   browserProxy_: null,
 
   /** @override */
   attached: function() {
     this.browserProxy_ = settings.ImportDataBrowserProxyImpl.getInstance();
     this.browserProxy_.initializeImportDialog().then(
         /** @param {!Array<!settings.BrowserProfile>} data */
         function(data) {
           this.browserProfiles_ = data;
           this.selected_ = this.browserProfiles_[0];
 
           // Show the dialog only after the browser profiles data is populated
           // to avoid UI flicker.
           this.$.dialog.showModal();
         }.bind(this));
 
     this.addWebUIListener(
         'import-data-status-changed',
         /** @param {settings.ImportDataStatus} importStatus */
         function(importStatus) {
           this.importStatus_ = importStatus;
+          if (this.hasImportStatus_(settings.ImportDataStatus.SUCCEEDED)) {
+            this.showBookmarkSuccess_ =
+                this.$.favorites.checked && this.selected_.favorites;
+          }
+
           if (this.hasImportStatus_(settings.ImportDataStatus.FAILED))
             this.closeDialog_();
         }.bind(this));
   },
 
   /** @private */
-  prefsChanged_: function() {
+  onCheckboxChange_: function() {
     this.noImportDataTypeSelected_ =
-        !(this.getPref('import_history').value && this.selected_.history) &&
-        !(this.getPref('import_bookmarks').value && this.selected_.favorites) &&
-        !(this.getPref('import_saved_passwords').value &&
-            this.selected_.passwords) &&
-        !(this.getPref('import_search_engine').value &&
-            this.selected_.search) &&
-        !(this.getPref('import_autofill_form_data').value &&
-            this.selected_.autofillFormData);
+        !(this.$.history.checked && this.selected_.history) &&

[Dan Beam, 2017/02/27 18:39:24]

arguable nit: we should reverse these conditionals, as we shouldn't be querying
the DOM's checked-ness if it's invalid (i.e. hidden but checked)

ex:

  !(this.selected_.history && this.$.history.checked) &&

[dpapad, 2017/02/27 19:55:00]

Done.

+        !(this.$.favorites.checked && this.selected_.favorites) &&
+        !(this.$.passwords.checked && this.selected_.passwords) &&
+        !(this.$.search.checked && this.selected_.search) &&
+        !(this.$.autofillFormData.checked && this.selected_.autofillFormData);
   },
 
   /**
    * @param {!settings.ImportDataStatus} status
    * @return {boolean} Whether |status| is the current status.
    * @private
    */
   hasImportStatus_: function(status) {
     return this.importStatus_ == status;
   },
@@ skipping 10 matching lines @@
    * @private
    */
   getActionButtonText_: function() {
     return this.i18n(this.isImportFromFileSelected_() ?
         'importChooseFile' : 'importCommit');
   },
 
   /** @private */
   onBrowserProfileSelectionChange_: function() {
     this.selected_ = this.browserProfiles_[this.$.browserSelect.selectedIndex];
+    this.onCheckboxChange_();
   },
 
   /** @private */
   onActionButtonTap_: function() {
     if (this.isImportFromFileSelected_())
       this.browserProxy_.importFromBookmarksFile();
     else
       this.browserProxy_.importData(this.$.browserSelect.selectedIndex);
   },
 
   /** @private */
   closeDialog_: function() {
     this.$.dialog.close();
   },
 
   /**
    * @return {boolean} Whether the import button should be disabled.
    * @private
    */
   shouldDisableImport_: function() {
     return this.hasImportStatus_(settings.ImportDataStatus.IN_PROGRESS) ||
         this.noImportDataTypeSelected_;
   },
 });