Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/LayoutTests/inspector/components/datagrid-test.js

Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/components/datagrid-test.js
diff --git a/third_party/WebKit/LayoutTests/inspector/components/datagrid-test.js b/third_party/WebKit/LayoutTests/inspector/components/datagrid-test.js
index 55f0262ccebaf4eccb970b6ca442b67a8aee00a6..e4a8f5e1e3342ff9347021b0dc56b6c83d5eb727 100644
--- a/third_party/WebKit/LayoutTests/inspector/components/datagrid-test.js
+++ b/third_party/WebKit/LayoutTests/inspector/components/datagrid-test.js
@@ -28,21 +28,21 @@ InspectorTest.validateDataGrid = function(root)
var children = root.children;
for (var i = 0; i < children.length; ++i) {
var child = children[i];
- if (child.parent !== root)
+ if (child.parent() !== root)
throw "Wrong parent for child " + child.data.id + " of " + root.data.id;
if (child.nextSibling !== (i + 1 === children.length ? null : children[i + 1]))
throw "Wrong child.nextSibling for " + child.data.id + " (" + i + " of " + children.length + ") ";
if (child.previousSibling !== (i ? children[i - 1] : null))
throw "Wrong child.previousSibling for " + child.data.id + " (" + i + " of " + children.length + ") ";
- if (child.parent && !child.parent._isRoot && child.depth !== root.depth + 1)
+ if (child.parent() && !child.parent()._isRoot && child.depth !== root.depth + 1)
throw "Wrong depth for " + child.data.id + " expected " + (root.depth + 1) + " but got " + child.depth;
InspectorTest.validateDataGrid(child);
}
var selectedNode = root.dataGrid.selectedNode;
- if (!root.parent && selectedNode) {
+ if (!root.parent() && selectedNode) {
if (!selectedNode.selectable)
throw "Selected node is not selectable";
- for (var node = selectedNode; node && node !== root; node = node.parent) { }
+ for (var node = selectedNode; node && node !== root; node = node.parent()) { }
if (!node)
throw "Selected node (" + selectedNode.data.id + ") is not within the DataGrid";
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698