third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html - Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter (Closed)

Patch Set: [Devtools] Moved DataGridNode's .parent property to proper getter/setter Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html ('k') | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js » ('j') | third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

diff --git a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

index c11a6eedecbd4dd58e88cabdfb89c9951ebbd468..6eb462358dbe6e45472e1dcb37a5ed8773732a39 100644

--- a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

+++ b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

@@ -88,8 +88,8 @@ function test()

InspectorTest.addResult("FAIL: node @" + nodeId + " not found");

return next();

}

- if (constructorName !== node.parent._name) {

- InspectorTest.addResult("FAIL: constructor name doesn't match. " + constructorName + " !== " + node.parent._name);

+ if (constructorName !== node.parent()._name) {

+ InspectorTest.addResult("FAIL: constructor name doesn't match. " + constructorName + " !== " + node.parent()._name);

next();

}

if (nodeId != node.snapshotNodeId) {