Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 795 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 this._setHoveredNode(null); 806 this._setHoveredNode(null);
807 807
808 if (!isFilteredOut) 808 if (!isFilteredOut)
809 nodesToRefresh.push(node); 809 nodesToRefresh.push(node);
810 var request = node.request(); 810 var request = node.request();
811 this._timeCalculator.updateBoundaries(request); 811 this._timeCalculator.updateBoundaries(request);
812 this._durationCalculator.updateBoundaries(request); 812 this._durationCalculator.updateBoundaries(request);
813 813
814 node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut; 814 node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
815 var newParent = this._parentNodeForInsert(node); 815 var newParent = this._parentNodeForInsert(node);
816 var removeFromParent = node.parent && (isFilteredOut || node.parent !== ne wParent); 816 var removeFromParent = node.parent() && (isFilteredOut || node.parent() != = newParent);
817 if (removeFromParent) { 817 if (removeFromParent) {
818 var parent = node.parent; 818 var parent = node.parent();
819 parent.removeChild(node); 819 parent.removeChild(node);
820 while (parent && !parent.hasChildren() && parent.dataGrid && parent.data Grid.rootNode() !== parent) { 820 while (parent && !parent.hasChildren() && parent.dataGrid && parent.data Grid.rootNode() !== parent) {
821 var grandparent = parent.parent; 821 var grandparent = parent.parent();
822 grandparent.removeChild(parent); 822 grandparent.removeChild(parent);
823 parent = grandparent; 823 parent = grandparent;
824 } 824 }
825 } 825 }
826 826
827 if (!newParent || isFilteredOut) 827 if (!newParent || isFilteredOut)
828 continue; 828 continue;
829 829
830 if (!newParent.dataGrid && !nodesToInsert.has(newParent)) { 830 if (!newParent.dataGrid && !nodesToInsert.has(newParent)) {
831 nodesToInsert.set(newParent, this._dataGrid.rootNode()); 831 nodesToInsert.set(newParent, this._dataGrid.rootNode());
(...skipping 960 matching lines...) Expand 10 before | Expand all | Expand 10 after
1792 */ 1792 */
1793 Network.NetworkGroupLookupInterface = function() {}; 1793 Network.NetworkGroupLookupInterface = function() {};
1794 1794
1795 Network.NetworkGroupLookupInterface.prototype = { 1795 Network.NetworkGroupLookupInterface.prototype = {
1796 /** 1796 /**
1797 * @param {!SDK.NetworkRequest} request 1797 * @param {!SDK.NetworkRequest} request
1798 * @return {?string} 1798 * @return {?string}
1799 */ 1799 */
1800 lookup(request) {} 1800 lookup(request) {}
1801 }; 1801 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698