third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html - Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

Issue 2716983002: [Devtools] Moved DataGridNode's .parent property to proper getter/setter (Closed)

Patch Set: [Devtools] Moved DataGridNode's .parent property to proper getter/setter Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html ('k') | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js » ('j') | third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="heap-snapshot-test.js"></script>	4 <script src="heap-snapshot-test.js"></script>

5 <script>	5 <script>

6	6

7 function test()	7 function test()

8 {	8 {

9 var instanceCount = 200;	9 var instanceCount = 200;

10 function createHeapSnapshot()	10 function createHeapSnapshot()

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
81 addNodeSelectSniffer("A", "401", next);	81 addNodeSelectSniffer("A", "401", next);

82 view.performSearch({query: "@401", caseSensitive: false});	82 view.performSearch({query: "@401", caseSensitive: false});

83 }	83 }

84	84

85 function checkNodeIsSelected(constructorName, nodeId, onSuccess, nod e)	85 function checkNodeIsSelected(constructorName, nodeId, onSuccess, nod e)

86 {	86 {

87 if (!node) {	87 if (!node) {

88 InspectorTest.addResult("FAIL: node @" + nodeId + " not foun d");	88 InspectorTest.addResult("FAIL: node @" + nodeId + " not foun d");

89 return next();	89 return next();

90 }	90 }

91 if (constructorName !== node.parent._name) {	91 if (constructorName !== node.parent()._name) {

92 InspectorTest.addResult("FAIL: constructor name doesn't matc h. " + constructorName + " !== " + node.parent._name);	92 InspectorTest.addResult("FAIL: constructor name doesn't matc h. " + constructorName + " !== " + node.parent()._name);

93 next();	93 next();

94 }	94 }

95 if (nodeId != node.snapshotNodeId) {	95 if (nodeId != node.snapshotNodeId) {

96 InspectorTest.addResult("FAIL: snapshot node id doesn't matc h. " + nodeId + " !== " + node.snapshotNodeId);	96 InspectorTest.addResult("FAIL: snapshot node id doesn't matc h. " + nodeId + " !== " + node.snapshotNodeId);

97 next();	97 next();

98 }	98 }

99 InspectorTest.addResult("PASS: found node @" + nodeId + " with c lass '" + constructorName + "'");	99 InspectorTest.addResult("PASS: found node @" + nodeId + " with c lass '" + constructorName + "'");

100 return onSuccess();	100 return onSuccess();

101 }	101 }

102 }	102 }

103 ]);	103 ]);

104 }	104 }

105	105

106 </script>	106 </script>

107 </head>	107 </head>

108 <body onload="runTest()">	108 <body onload="runTest()">

109 <p>	109 <p>

110 Tests search in Summary view of detailed heap snapshots.	110 Tests search in Summary view of detailed heap snapshots.

111 </p>	111 </p>

112 </body>	112 </body>

113 </html>	113 </html>

OLD	NEW