Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 271693004: Change multi-client Sync tests to use FakeServer (Closed)

Created:
6 years, 7 months ago by pval...(no longer on Chromium)
Modified:
6 years, 7 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, David Abrahams
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change multi-client Sync tests to use FakeServer BUG=323265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270251

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pval...(no longer on Chromium)
I will wait until https://codereview.chromium.org/267743003/ is landed before landing this.
6 years, 7 months ago (2014-05-07 21:13:01 UTC) #1
rlarocque
LGTM.
6 years, 7 months ago (2014-05-09 23:19:55 UTC) #2
pval...(no longer on Chromium)
The CQ bit was checked by pvalenzuela@chromium.org
6 years, 7 months ago (2014-05-13 21:53:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pvalenzuela@chromium.org/271693004/20001
6 years, 7 months ago (2014-05-13 22:05:12 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 23:53:45 UTC) #5
Message was sent while issue was closed. 
Change committed as 270251

Powered by Google App Engine
This is Rietveld 408576698