Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 27169003: Enable correct behaviour for deleting regional indicator symbols (Closed)

Created:
7 years, 2 months ago by wolanski
Modified:
7 years, 1 month ago
Reviewers:
lgombos, hamaji, eae, Inactive, ojan
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1, ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable correct behaviour for deleting regional indicator symbols on Linux OS Regional indicator symbols that are combined should behave as a single character when deleting. BUG=306948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160954

Patch Set 1 #

Patch Set 2 : apply suggestions #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
A + LayoutTests/platform/linux/editing/deleting/regional-indicators-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 5 chunks +3 lines, -6 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
wolanski
7 years, 2 months ago (2013-10-14 10:23:26 UTC) #1
wolanski
7 years, 2 months ago (2013-10-15 07:27:05 UTC) #2
ojan
7 years, 2 months ago (2013-10-15 22:22:05 UTC) #3
eae
Instead of deleting the windows results for editing/deleting/regional-indicators-expected.txt and adding it to TestExpectations could you ...
7 years, 2 months ago (2013-10-15 22:28:45 UTC) #4
wolanski
On 2013/10/15 22:28:45, eae wrote: > Instead of deleting the windows results for > editing/deleting/regional-indicators-expected.txt ...
7 years, 2 months ago (2013-10-18 07:50:11 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-10-28 12:59:42 UTC) #6
eae
LGTM
7 years, 1 month ago (2013-10-30 16:30:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.wolanski@samsung.com/27169003/6001
7 years, 1 month ago (2013-10-30 16:30:18 UTC) #8
commit-bot: I haz the power
Change committed as 160954
7 years, 1 month ago (2013-10-30 17:49:43 UTC) #9
lgombos
https://codereview.chromium.org/27169003/diff/6001/Source/core/rendering/RenderText.cpp File Source/core/rendering/RenderText.cpp (right): https://codereview.chromium.org/27169003/diff/6001/Source/core/rendering/RenderText.cpp#newcode1675 Source/core/rendering/RenderText.cpp:1675: #if OS(MACOSX) || OS(LINUX) Should this be OS(POSIX) instead ...
7 years, 1 month ago (2013-10-31 02:18:51 UTC) #10
wolanski
7 years, 1 month ago (2013-10-31 10:10:53 UTC) #11
Message was sent while issue was closed.
On 2013/10/31 02:18:51, lgombos wrote:
>
https://codereview.chromium.org/27169003/diff/6001/Source/core/rendering/Rend...
> File Source/core/rendering/RenderText.cpp (right):
> 
>
https://codereview.chromium.org/27169003/diff/6001/Source/core/rendering/Rend...
> Source/core/rendering/RenderText.cpp:1675: #if OS(MACOSX) || OS(LINUX)
> Should this be OS(POSIX) instead to include Android as well ?

Ok, I will fix it.

Powered by Google App Engine
This is Rietveld 408576698