More robust fill password fields on click.

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 1414 matching lines @@
     PasswordInfo password_info;
     password_info.fill_data = form_data;
     password_info.key = key;
     password_info.password_field = password_element;
     web_input_to_password_info_[main_element] = password_info;
     if (!main_element.isPasswordField())
       password_to_username_[password_element] = username_element;
     if (elements)
       elements->push_back(main_element);
   }
+
+  // This is a fallback, if for some reasons elements for filling were not found
+  // (for example because they were renamed by JavaScript) then add fill data
+  // for |web_input_to_password_info_| in order to be able propose filling of
+  // password fields on click.
+  if (web_input_to_password_info_.empty()) {
+    PasswordInfo password_info;
+    password_info.fill_data = form_data;
+    password_info.key = key;
+    web_input_to_password_info_[blink::WebInputElement()] = password_info;

[vabr (Chromium), 2017/02/24 20:10:36]

Could you explain in a code comment, how the |password_info| is retrieved if the
key is a non-existing WebInputElement?
(I suppose it is because PasswordAutofillAgent::FindPasswordInfoForElement will
take the first pair in web_input_to_password_info_ in case there is no username
associated with the password?)

[dvadym, 2017/02/27 10:14:29]

Yeah, your explanation is correct, I've updated the comment

+  }
 }
 
 void PasswordAutofillAgent::FocusedNodeHasChanged(const blink::WebNode& node) {
   if (node.isNull() || !node.isElementNode())
     return;
   const blink::WebElement web_element = node.toConst<blink::WebElement>();
   if (!web_element.isFormControlElement())
     return;
   const blink::WebFormControlElement control_element =
       web_element.toConst<blink::WebFormControlElement>();
@@ skipping 140 matching lines @@
 PasswordAutofillAgent::GetPasswordManagerDriver() {
   if (!password_manager_driver_) {
     render_frame()->GetRemoteInterfaces()->GetInterface(
         mojo::MakeRequest(&password_manager_driver_));
   }
 
   return password_manager_driver_;
 }
 
 }  // namespace autofill