Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 271683002: DevTools: Unflake test-cpu-profiler/JsNativeJsRuntimeJsSample (Closed)

Created:
6 years, 7 months ago by alph
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

DevTools: Unflake test-cpu-profiler/JsNativeJsRuntimeJsSample BUG=v8:3308 LOG=N R=bmeurer@chromium.org, jochen@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/profile-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
6 years, 7 months ago (2014-05-07 14:36:47 UTC) #1
yurys
lgtm
6 years, 7 months ago (2014-05-07 14:48:19 UTC) #2
Benedikt Meurer
lgtm
6 years, 7 months ago (2014-05-08 04:18:02 UTC) #3
jochen (gone - plz use gerrit)
lgtm, thanks
6 years, 7 months ago (2014-05-08 06:39:39 UTC) #4
alph
6 years, 7 months ago (2014-05-08 09:47:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r21198 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698