Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2716793004: Revert of Change focus indicator for TableView and TreeView. (Closed)

Created:
3 years, 10 months ago by lazyboy
Modified:
3 years, 10 months ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change focus indicator for TableView and TreeView. (patchset #4 id:60001 of https://codereview.chromium.org/2715813002/ ) Reason for revert: Breaking build with [chromium-style] error. ../../ui/views/controls/scroll_view.cc:184:3: error: [chromium-style] auto variable type must not deduce to a raw pointer type. auto scroll_view = new ScrollView(); ^~~~ auto* Original issue's description: > Change focus indicator for TableView and TreeView. > > This affects surfaces such as the task manager, the bookmark bubble > editor, and the cookies view. > > The indicator for selection (the background of the row) is unchanged. > When the window is focused, instead of drawing a dashed focus rect > which looks dated and especially bad at fractional scales, we draw the > table/tree's border in blue. This matches textfields and the general > trend of blue outlines/rings for focus indication. > > This will change in Harmony to be a focus ring so it's mainly just an > interim solution that makes the current state of the world look less > bad while we wait for Harmony to arrive. > > BUG=695540 > > Review-Url: https://codereview.chromium.org/2715813002 > Cr-Commit-Position: refs/heads/master@{#452876} > Committed: https://chromium.googlesource.com/chromium/src/+/f084da03407bcb848d8ef8f232c28db56883d648 TBR=tapted@chromium.org,ellyjones@chromium.org,sky@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -87 lines) Patch
M chrome/browser/ui/views/collected_cookies_views.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/controls/scroll_view.h View 5 chunks +2 lines, -17 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 6 chunks +25 lines, -52 lines 0 comments Download
M ui/views/controls/table/table_view.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M ui/views/controls/tree/tree_view.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/controls/tree/tree_view.cc View 4 chunks +16 lines, -7 lines 0 comments Download
M ui/views/style/platform_style.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/style/platform_style.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/style/platform_style_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lazyboy
Created Revert of Change focus indicator for TableView and TreeView.
3 years, 10 months ago (2017-02-24 19:01:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716793004/1
3 years, 10 months ago (2017-02-24 19:03:25 UTC) #3
Evan Stade
3 years, 10 months ago (2017-02-24 19:10:51 UTC) #5
This new check was added after my change landed and this is a one character fix.
I'm going to just fix it now.

Powered by Google App Engine
This is Rietveld 408576698