Chromium Code Reviews
DescriptionRevert of Change focus indicator for TableView and TreeView. (patchset #4 id:60001 of https://codereview.chromium.org/2715813002/ )
Reason for revert:
Breaking build with [chromium-style] error.
../../ui/views/controls/scroll_view.cc:184:3: error: [chromium-style] auto variable type must not deduce to a raw pointer type.
auto scroll_view = new ScrollView();
^~~~
auto*
Original issue's description:
> Change focus indicator for TableView and TreeView.
>
> This affects surfaces such as the task manager, the bookmark bubble
> editor, and the cookies view.
>
> The indicator for selection (the background of the row) is unchanged.
> When the window is focused, instead of drawing a dashed focus rect
> which looks dated and especially bad at fractional scales, we draw the
> table/tree's border in blue. This matches textfields and the general
> trend of blue outlines/rings for focus indication.
>
> This will change in Harmony to be a focus ring so it's mainly just an
> interim solution that makes the current state of the world look less
> bad while we wait for Harmony to arrive.
>
> BUG=695540
>
> Review-Url: https://codereview.chromium.org/2715813002
> Cr-Commit-Position: refs/heads/master@{#452876}
> Committed: https://chromium.googlesource.com/chromium/src/+/f084da03407bcb848d8ef8f232c28db56883d648
TBR=tapted@chromium.org,ellyjones@chromium.org,sky@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695540
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||