Chromium Code Reviews Chromium Code Reviews
Issue 271673005:
Oilpan: move DOMImplementation to the heap. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/dom/DOMImplementation.cpp |
| diff --git a/Source/core/dom/DOMImplementation.cpp b/Source/core/dom/DOMImplementation.cpp |
| index 8b5297e622bd7a350885fccd2d091b75360ee886..96df8e21d69af204aec348ab1ae03694d6f9291b 100644 |
| --- a/Source/core/dom/DOMImplementation.cpp |
| +++ b/Source/core/dom/DOMImplementation.cpp |
| @@ -161,7 +161,7 @@ static bool isSupportedSVG11Feature(const String& feature, const String& version |
| && svgFeatures.contains(feature.right(feature.length() - 35)); |
| } |
| -DOMImplementation::DOMImplementation(Document& document) |
| +DOMImplementation::DOMImplementation(Document* document) |
| : m_document(document) |
| { |
| ScriptWrappable::init(this); |
| @@ -194,24 +194,24 @@ PassRefPtr<DocumentType> DOMImplementation::createDocumentType(const AtomicStrin |
| if (!Document::parseQualifiedName(qualifiedName, prefix, localName, exceptionState)) |
| return nullptr; |
| - return DocumentType::create(&m_document, qualifiedName, publicId, systemId); |
| + return DocumentType::create(m_document, qualifiedName, publicId, systemId); |
| } |
| PassRefPtr<XMLDocument> DOMImplementation::createDocument(const AtomicString& namespaceURI, |
| const AtomicString& qualifiedName, DocumentType* doctype, ExceptionState& exceptionState) |
| { |
| RefPtr<XMLDocument> doc; |
| - DocumentInit init = DocumentInit::fromContext(m_document.contextDocument()); |
| + DocumentInit init = DocumentInit::fromContext(m_document->contextDocument()); |
|
tkent
2014/05/07 23:43:20
Please use document() instead of m_document.
|
| if (namespaceURI == SVGNames::svgNamespaceURI) { |
| doc = XMLDocument::createSVG(init); |
| } else if (namespaceURI == HTMLNames::xhtmlNamespaceURI) { |
| - doc = XMLDocument::createXHTML(init.withRegistrationContext(m_document.registrationContext())); |
| + doc = XMLDocument::createXHTML(init.withRegistrationContext(m_document->registrationContext())); |
| } else { |
| doc = XMLDocument::create(init); |
| } |
| - doc->setSecurityOrigin(m_document.securityOrigin()->isolatedCopy()); |
| - doc->setContextFeatures(m_document.contextFeatures()); |
| + doc->setSecurityOrigin(m_document->securityOrigin()->isolatedCopy()); |
| + doc->setContextFeatures(m_document->contextFeatures()); |
| RefPtr<Node> documentElement; |
| if (!qualifiedName.isEmpty()) { |
| @@ -320,15 +320,15 @@ bool DOMImplementation::isTextMIMEType(const String& mimeType) |
| PassRefPtr<HTMLDocument> DOMImplementation::createHTMLDocument(const String& title) |
| { |
| - DocumentInit init = DocumentInit::fromContext(m_document.contextDocument()) |
| - .withRegistrationContext(m_document.registrationContext()); |
| + DocumentInit init = DocumentInit::fromContext(m_document->contextDocument()) |
| + .withRegistrationContext(m_document->registrationContext()); |
| RefPtr<HTMLDocument> d = HTMLDocument::create(init); |
| d->open(); |
| d->write("<!doctype html><html><body></body></html>"); |
| if (!title.isNull()) |
| d->setTitle(title); |
| - d->setSecurityOrigin(m_document.securityOrigin()->isolatedCopy()); |
| - d->setContextFeatures(m_document.contextFeatures()); |
| + d->setSecurityOrigin(m_document->securityOrigin()->isolatedCopy()); |
| + d->setContextFeatures(m_document->contextFeatures()); |
| return d.release(); |
| } |
| @@ -378,4 +378,9 @@ PassRefPtr<Document> DOMImplementation::createDocument(const String& type, const |
| return HTMLDocument::create(init); |
| } |
| +void DOMImplementation::trace(Visitor* visitor) |
| +{ |
| + visitor->trace(m_document); |
| +} |
| + |
| } |
