Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2716713003: Move main and isolate handling to enqueuer listeners. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move main and isolate handling to enqueuer listeners. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9420ab5f3c9db487b69d5e83904a333005fdaf31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -142 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 11 chunks +36 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +0 lines, -65 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 2 chunks +52 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 6 chunks +66 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/tool/perf.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-24 15:25:05 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 9 months ago (2017-03-11 00:50:37 UTC) #3
Johnni Winther
3 years, 9 months ago (2017-03-11 10:26:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9420ab5f3c9db487b69d5e83904a333005fdaf31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698