Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js |
| index a578b774e1ce12d82f7b5394b17dde3d361e68e0..0364c2e337f46abbe40a0fbf421c2d98ae80b45f 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js |
| @@ -489,10 +489,10 @@ UI.TabbedPane = class extends UI.VBox { |
| } |
| /** |
| - * @param {string} text |
| + * @param {!Element} element |
| */ |
| - setPlaceholderText(text) { |
| - this._noTabsMessage = text; |
| + setPlaceholderElement(element) { |
|
pfeldman
2017/04/26 00:02:21
This call seems to have no effect on its own.
luoe
2017/04/26 01:40:56
Semantically, calling setPlaceholderElement() afte
|
| + this._placeholderElement = element; |
| } |
| _innerUpdateTabElements() { |
| @@ -501,15 +501,15 @@ UI.TabbedPane = class extends UI.VBox { |
| if (!this._tabs.length) { |
| this._contentElement.classList.add('has-no-tabs'); |
| - if (this._noTabsMessage && !this._noTabsMessageElement) { |
| - this._noTabsMessageElement = this._contentElement.createChild('div', 'tabbed-pane-placeholder fill'); |
| - this._noTabsMessageElement.textContent = this._noTabsMessage; |
| + if (this._placeholderElement && !this._placeholderContainerElement) { |
| + this._placeholderContainerElement = this._contentElement.createChild('div', 'tabbed-pane-placeholder fill'); |
| + this._placeholderContainerElement.appendChild(this._placeholderElement); |
| } |
| } else { |
| this._contentElement.classList.remove('has-no-tabs'); |
| - if (this._noTabsMessageElement) { |
| - this._noTabsMessageElement.remove(); |
| - delete this._noTabsMessageElement; |
| + if (this._placeholderContainerElement) { |
| + this._placeholderContainerElement.remove(); |
| + delete this._placeholderContainerElement; |
| } |
| } |