Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

Issue 2716683006: DevTools: add entry points for command menu (Closed)
Patch Set: ac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
index a578b774e1ce12d82f7b5394b17dde3d361e68e0..81bbe255a0edbd20ad79e30667e89d4559b59189 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
@@ -489,10 +489,15 @@ UI.TabbedPane = class extends UI.VBox {
}
/**
- * @param {string} text
+ * @param {!Element} element
*/
- setPlaceholderText(text) {
- this._noTabsMessage = text;
+ setPlaceholderElement(element) {
+ this._placeholderElement = element;
+
+ if (this._placeholderContainerElement) {
+ this._placeholderContainerElement.removeChildren();
+ this._placeholderContainerElement.appendChild(element);
+ }
}
_innerUpdateTabElements() {
@@ -501,15 +506,15 @@ UI.TabbedPane = class extends UI.VBox {
if (!this._tabs.length) {
this._contentElement.classList.add('has-no-tabs');
- if (this._noTabsMessage && !this._noTabsMessageElement) {
- this._noTabsMessageElement = this._contentElement.createChild('div', 'tabbed-pane-placeholder fill');
- this._noTabsMessageElement.textContent = this._noTabsMessage;
+ if (this._placeholderElement && !this._placeholderContainerElement) {
+ this._placeholderContainerElement = this._contentElement.createChild('div', 'tabbed-pane-placeholder fill');
+ this._placeholderContainerElement.appendChild(this._placeholderElement);
}
} else {
this._contentElement.classList.remove('has-no-tabs');
- if (this._noTabsMessageElement) {
- this._noTabsMessageElement.remove();
- delete this._noTabsMessageElement;
+ if (this._placeholderContainerElement) {
+ this._placeholderContainerElement.remove();
+ delete this._placeholderContainerElement;
}
}

Powered by Google App Engine
This is Rietveld 408576698