Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

Issue 2716683006: DevTools: add entry points for command menu (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
index e3dff50bbfe3d674745788a93514f9130649fc04..172cc6342f1e809ef77ef41b37e09904eb83c73a 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
@@ -45,7 +45,8 @@ UI.TabbedPane = class extends UI.VBox {
this._tabsElement.setAttribute('role', 'tablist');
this._contentElement = this.contentElement.createChild('div', 'tabbed-pane-content');
this._contentElement.setAttribute('role', 'tabpanel');
- this._contentElement.createChild('content');
+ var contentTag = this._contentElement.createChild('content');
+ contentTag.createChild('span', 'content child');
chenwilliam 2017/02/25 00:56:43 remove this?
luoe 2017/03/09 18:48:28 Done.
/** @type {!Array.<!UI.TabbedPaneTab>} */
this._tabs = [];
/** @type {!Array.<!UI.TabbedPaneTab>} */
@@ -489,10 +490,10 @@ UI.TabbedPane = class extends UI.VBox {
}
/**
- * @param {string} text
+ * @param {!Element} element
*/
- setPlaceholderText(text) {
- this._noTabsMessage = text;
+ setPlaceholderElement(element) {
+ this._noTabsMessageElement = element;
}
_innerUpdateTabElements() {
@@ -501,10 +502,8 @@ UI.TabbedPane = class extends UI.VBox {
if (!this._tabs.length) {
this._contentElement.classList.add('has-no-tabs');
- if (this._noTabsMessage && !this._noTabsMessageElement) {
- this._noTabsMessageElement = this._contentElement.createChild('div', 'tabbed-pane-placeholder fill');
- this._noTabsMessageElement.textContent = this._noTabsMessage;
- }
+ if (this._noTabsMessageElement)
+ this.element.appendChild(this._noTabsMessageElement);
} else {
this._contentElement.classList.remove('has-no-tabs');
if (this._noTabsMessageElement) {

Powered by Google App Engine
This is Rietveld 408576698