Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2587)

Unified Diff: dashboard/dashboard/static/series_group.html

Issue 2716683004: [Dashboard] Start using /list_tests's test_path_dict mode in test-picker (Closed)
Patch Set: fix v8 case Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/static/series_group.html
diff --git a/dashboard/dashboard/static/series_group.html b/dashboard/dashboard/static/series_group.html
index 07337ded114f8f824cf9caaac8e8d635b062672e..b82d1066a5c2adec7855c4ed677710e56424f76e 100644
--- a/dashboard/dashboard/static/series_group.html
+++ b/dashboard/dashboard/static/series_group.html
@@ -53,8 +53,13 @@ tr.exportTo('d', function() {
const unselectedTests = simple_xhr.asPromise(
'list_tests', unselectedParams);
+ // TODO(eakuefner): Make this error handling better. See
+ // https://github.com/catapult-project/catapult/issues/3391.
return Promise.all([selectedTests, unselectedTests]).then(
- tests => new SeriesGroup(mainPath, ...tests));
+ tests => new SeriesGroup(mainPath, ...tests),
+ reason => {
+ throw new Error(reason);
+ });
};
/**
@@ -76,7 +81,7 @@ tr.exportTo('d', function() {
return {
type: 'test_path_dict',
test_path_dict: JSON.stringify(testPathDict(...legacyChartStateElement)),
- selected: selectedStr
+ return_selected: selectedStr
};
}
« no previous file with comments | « dashboard/dashboard/elements/test-picker-test.html ('k') | dashboard/dashboard/static/series_group_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698