Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2716593002: Propagate this-specialization to regular (megamorphic) calls (Closed)

Created:
3 years, 10 months ago by erikcorry
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Propagate this-specialization to regular (megamorphic) calls R=vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c0404e4f23e4c3bfbafd3efc5fa6c80a077a4e3d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Cleanups #

Total comments: 2

Patch Set 3 : Add new Canonicalize call to make use of type data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -62 lines) Patch
M runtime/vm/aot_optimizer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 1 chunk +0 lines, -27 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/vm/jit_optimizer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/jit_optimizer.cc View 1 2 2 chunks +2 lines, -28 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
erikcorry
3 years, 10 months ago (2017-02-23 13:59:43 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2716593002/diff/1/runtime/vm/aot_optimizer.cc File runtime/vm/aot_optimizer.cc (right): https://codereview.chromium.org/2716593002/diff/1/runtime/vm/aot_optimizer.cc#newcode290 runtime/vm/aot_optimizer.cc:290: const ICData& AotOptimizer::TrySpecializeICData(const ICData& ic_data, I think this ...
3 years, 10 months ago (2017-02-23 15:32:38 UTC) #2
Vyacheslav Egorov (Google)
still lgtm
3 years, 9 months ago (2017-02-27 12:09:35 UTC) #3
erikcorry
3 years, 9 months ago (2017-02-27 12:29:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c0404e4f23e4c3bfbafd3efc5fa6c80a077a4e3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698