Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2716583006: Fix Function.apply (Closed)

Created:
3 years, 10 months ago by vsm
Modified:
3 years, 10 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -6 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 4 chunks +0 lines, -4 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vsm
3 years, 10 months ago (2017-02-25 00:21:06 UTC) #3
Alan Knight
lgtm
3 years, 10 months ago (2017-02-25 01:08:49 UTC) #4
Jennifer Messerly
Is there a test for this? otherwise LGTM
3 years, 10 months ago (2017-02-25 01:13:45 UTC) #5
Jennifer Messerly
On 2017/02/25 01:13:45, Jennifer Messerly wrote: > Is there a test for this? > > ...
3 years, 10 months ago (2017-02-25 01:14:24 UTC) #6
vsm
3 years, 10 months ago (2017-02-25 03:24:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53971cb67e71c38a2d1a5ae881a1925b29637a00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698