third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)

Patch Set: Avoid computing constraints for non-anchored sticky and add/update tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index c715a2954ec4c2eafbe10594703a5a5c310ac30e..6d7a23bdbae19f8b2648ab484e85a0d9fd1fa8b1 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -294,7 +294,7 @@ void CompositedLayerMapping::updateBackdropFilters(const ComputedStyle& style) {

void CompositedLayerMapping::updateStickyConstraints(

const ComputedStyle& style,

const PaintLayer* compositingContainer) {

- bool sticky = style.position() == EPosition::kSticky;

+ bool sticky = style.hasStickyConstrainedPosition();

const PaintLayer* ancestorOverflowLayer =

m_owningLayer.ancestorOverflowLayer();

// TODO(flackr): Do we still need this?