third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)

Patch Set: Avoid computing constraints for non-anchored sticky and add/update tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 89fd2d55ca862fd8b6f4e7e78161f177f9810990..57f517c40484e71d9a0c381c6f7d3a5091767411 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -1063,7 +1063,7 @@ LayoutBox* LayoutBox::findAutoscrollable(LayoutObject* layoutObject) {

!(layoutObject->isBox() && toLayoutBox(layoutObject)->canAutoscroll())) {

// Do not start autoscroll when the node is inside a fixed-position element.

if (layoutObject->isBox() && toLayoutBox(layoutObject)->hasLayer() &&

- toLayoutBox(layoutObject)->layer()->sticksToViewport()) {

+ toLayoutBox(layoutObject)->layer()->fixedToViewport()) {

return nullptr;

}