third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index 2f088385197aa537e54a8c6e26e1e6e6f8b38986..7b007f619100cca2ce66920deaa21b9a0356db37 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -208,7 +208,8 @@ void LayoutBoxModelObject::willBeDestroyed() {

// 0 during destruction.

if (LocalFrame* frame = this->frame()) {

if (FrameView* frameView = frame->view()) {

- if (style()->hasViewportConstrainedPosition())

+ if (style()->hasViewportConstrainedPosition() ||

+ style()->hasStickyConstrainedPosition())

frameView->removeViewportConstrainedObject(*this);

}