Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)
Patch Set: Avoid computing constraints for non-anchored sticky and add/update tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1543 matching lines...) Expand 10 before | Expand all | Expand 10 after
1554 d->m_stickyConstraintsMap.clear(); 1554 d->m_stickyConstraintsMap.clear();
1555 } 1555 }
1556 } 1556 }
1557 1557
1558 void PaintLayerScrollableArea::invalidateStickyConstraintsFor( 1558 void PaintLayerScrollableArea::invalidateStickyConstraintsFor(
1559 PaintLayer* layer, 1559 PaintLayer* layer,
1560 bool needsCompositingUpdate) { 1560 bool needsCompositingUpdate) {
1561 if (PaintLayerScrollableAreaRareData* d = rareData()) { 1561 if (PaintLayerScrollableAreaRareData* d = rareData()) {
1562 d->m_stickyConstraintsMap.remove(layer); 1562 d->m_stickyConstraintsMap.remove(layer);
1563 if (needsCompositingUpdate && 1563 if (needsCompositingUpdate &&
1564 layer->layoutObject().style()->position() == EPosition::kSticky) 1564 layer->layoutObject().style()->hasStickyConstrainedPosition())
1565 layer->setNeedsCompositingInputsUpdate(); 1565 layer->setNeedsCompositingInputsUpdate();
1566 } 1566 }
1567 } 1567 }
1568 1568
1569 IntSize PaintLayerScrollableArea::offsetFromResizeCorner( 1569 IntSize PaintLayerScrollableArea::offsetFromResizeCorner(
1570 const IntPoint& absolutePoint) const { 1570 const IntPoint& absolutePoint) const {
1571 // Currently the resize corner is either the bottom right corner or the bottom 1571 // Currently the resize corner is either the bottom right corner or the bottom
1572 // left corner. 1572 // left corner.
1573 // FIXME: This assumes the location is 0, 0. Is this guaranteed to always be 1573 // FIXME: This assumes the location is 0, 0. Is this guaranteed to always be
1574 // the case? 1574 // the case?
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
2149 2149
2150 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 2150 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
2151 clampScrollableAreas() { 2151 clampScrollableAreas() {
2152 for (auto& scrollableArea : *s_needsClamp) 2152 for (auto& scrollableArea : *s_needsClamp)
2153 scrollableArea->clampScrollOffsetAfterOverflowChange(); 2153 scrollableArea->clampScrollOffsetAfterOverflowChange();
2154 delete s_needsClamp; 2154 delete s_needsClamp;
2155 s_needsClamp = nullptr; 2155 s_needsClamp = nullptr;
2156 } 2156 }
2157 2157
2158 } // namespace blink 2158 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698