Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2716583005: Do not promote position sticky or fixed elements unless they move with scroll. (Closed)
Patch Set: Create a stacking context for sticky. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
4 * reserved. 4 * reserved.
5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 1188 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 // See crbug.com/663650 for more details." 1199 // See crbug.com/663650 for more details."
1200 if (transformStyle3D() == TransformStyle3DPreserve3D) { 1200 if (transformStyle3D() == TransformStyle3DPreserve3D) {
1201 setIsStackingContext(true); 1201 setIsStackingContext(true);
1202 return; 1202 return;
1203 } 1203 }
1204 1204
1205 if (isDocumentElement || isInTopLayer || styleType() == PseudoIdBackdrop || 1205 if (isDocumentElement || isInTopLayer || styleType() == PseudoIdBackdrop ||
1206 hasOpacity() || hasTransformRelatedProperty() || hasMask() || 1206 hasOpacity() || hasTransformRelatedProperty() || hasMask() ||
1207 clipPath() || boxReflect() || hasFilterInducingProperty() || 1207 clipPath() || boxReflect() || hasFilterInducingProperty() ||
1208 hasBackdropFilter() || hasBlendMode() || hasIsolation() || 1208 hasBackdropFilter() || hasBlendMode() || hasIsolation() ||
1209 hasViewportConstrainedPosition() || 1209 hasViewportConstrainedPosition() || position() == EPosition::kSticky ||
1210 hasPropertyThatCreatesStackingContext(willChangeProperties()) || 1210 hasPropertyThatCreatesStackingContext(willChangeProperties()) ||
1211 containsPaint()) { 1211 containsPaint()) {
1212 setIsStackingContext(true); 1212 setIsStackingContext(true);
1213 } 1213 }
1214 } 1214 }
1215 1215
1216 void ComputedStyle::addCallbackSelector(const String& selector) { 1216 void ComputedStyle::addCallbackSelector(const String& selector) {
1217 if (!m_rareNonInheritedData->m_callbackSelectors.contains(selector)) 1217 if (!m_rareNonInheritedData->m_callbackSelectors.contains(selector))
1218 m_rareNonInheritedData.access()->m_callbackSelectors.push_back(selector); 1218 m_rareNonInheritedData.access()->m_callbackSelectors.push_back(selector);
1219 } 1219 }
(...skipping 1279 matching lines...) Expand 10 before | Expand all | Expand 10 after
2499 if (value < 0) 2499 if (value < 0)
2500 fvalue -= 0.5f; 2500 fvalue -= 0.5f;
2501 else 2501 else
2502 fvalue += 0.5f; 2502 fvalue += 0.5f;
2503 } 2503 }
2504 2504
2505 return roundForImpreciseConversion<int>(fvalue / zoomFactor); 2505 return roundForImpreciseConversion<int>(fvalue / zoomFactor);
2506 } 2506 }
2507 2507
2508 } // namespace blink 2508 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698