components/password_manager/core/common/credential_manager_types_unittest.cc - Issue 2716583003: Rename Origin.unique() to opaque().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/credential_manager_types_unittest.cc

Issue 2716583003: Rename Origin.unique() to opaque().

Patch Set: Update new uses post-rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/psl_matching_helper.cc ('k') | components/subresource_filter/content/browser/async_document_subresource_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/credential_manager_types_unittest.cc

diff --git a/components/password_manager/core/common/credential_manager_types_unittest.cc b/components/password_manager/core/common/credential_manager_types_unittest.cc

index e1744b555a0b92fa330499b92a4d328cb72cc694..167b41dc06396c1c1690a0d2fc288e434e8f0159 100644

--- a/components/password_manager/core/common/credential_manager_types_unittest.cc

+++ b/components/password_manager/core/common/credential_manager_types_unittest.cc

@@ -81,7 +81,7 @@ TEST_F(CredentialManagerTypesTest, CreatePasswordFormLocal) {

// Local credentials have empty federation_origins, non-empty passwords, and

// a signon realm that matches the origin.

- EXPECT_TRUE(form->federation_origin.unique());

+ EXPECT_TRUE(form->federation_origin.opaque());

EXPECT_EQ(info.password, form->password_value);

EXPECT_EQ(origin_.spec(), form->signon_realm);

}

@@ -95,7 +95,7 @@ TEST_F(CredentialManagerTypesTest, CreateObservedPasswordForm) {

EXPECT_EQ(base::string16(), form->display_name);

EXPECT_EQ(origin_, form->origin);

EXPECT_EQ(autofill::PasswordForm::SCHEME_HTML, form->scheme);

- EXPECT_TRUE(form->federation_origin.unique());

+ EXPECT_TRUE(form->federation_origin.opaque());

EXPECT_EQ(base::string16(), form->password_value);

EXPECT_EQ(origin_.spec(), form->signon_realm);

}