components/password_manager/core/browser/credential_manager_impl.cc - Issue 2716583003: Rename Origin.unique() to opaque().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_impl.cc

Issue 2716583003: Rename Origin.unique() to opaque().

Patch Set: Update new uses post-rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/error_page/common/localized_error.cc ('k') | components/password_manager/core/browser/credential_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_impl.cc

diff --git a/components/password_manager/core/browser/credential_manager_impl.cc b/components/password_manager/core/browser/credential_manager_impl.cc

index 17b0ba65fe006fcead62d248091ada2ebf23d88a..08e7e6677c6a01ba5e7f659e04cf68bd404aec17 100644

--- a/components/password_manager/core/browser/credential_manager_impl.cc

+++ b/components/password_manager/core/browser/credential_manager_impl.cc

@@ -172,7 +172,7 @@ void CredentialManagerImpl::SendPasswordForm(

CredentialInfo info;

if (form) {

password_manager::CredentialType type_to_return =

- form->federation_origin.unique()

+ form->federation_origin.opaque()

? CredentialType::CREDENTIAL_TYPE_PASSWORD

: CredentialType::CREDENTIAL_TYPE_FEDERATED;

info = CredentialInfo(*form, type_to_return);

@@ -222,7 +222,7 @@ void CredentialManagerImpl::OnProvisionalSaveComplete() {

return;

}

- if (!form.federation_origin.unique()) {

+ if (!form.federation_origin.opaque()) {

// If this is a federated credential, check it against the federated matches

// produced by the PasswordFormManager. If a match is found, update it and

// return.