chrome/browser/notifications/notification_channels_provider_android.cc - Issue 2716583003: Rename Origin.unique() to opaque().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_channels_provider_android.cc

Issue 2716583003: Rename Origin.unique() to opaque().

Patch Set: Update new uses post-rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/password_manager/credential_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_channels_provider_android.cc

diff --git a/chrome/browser/notifications/notification_channels_provider_android.cc b/chrome/browser/notifications/notification_channels_provider_android.cc

index 66b4881dc67d474350b08cfd840d993dddac7871..92fd24fa2672803dd08bd752696091b6109414fb 100644

--- a/chrome/browser/notifications/notification_channels_provider_android.cc

+++ b/chrome/browser/notifications/notification_channels_provider_android.cc

@@ -222,7 +222,7 @@ bool NotificationChannelsProviderAndroid::SetWebsiteSetting(

InitCachedChannels();

url::Origin origin = url::Origin(GURL(primary_pattern.ToString()));

- DCHECK(!origin.unique());

+ DCHECK(!origin.opaque());

const std::string origin_string = origin.Serialize();

ContentSetting setting = content_settings::ValueToContentSetting(value);

@@ -277,7 +277,7 @@ base::Time NotificationChannelsProviderAndroid::GetWebsiteSettingLastModified(

return base::Time();

}

url::Origin origin = url::Origin(GURL(primary_pattern.ToString()));

- if (origin.unique())

+ if (origin.opaque())

return base::Time();

const std::string origin_string = origin.Serialize();